Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(open): Throw on incorrect baudrate option #1347

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Conversation

reconbot
Copy link
Member

This was causing a lot of issues, lets make it easier on people.

This was causing a lot of issues, lets make it easier on people.
@reconbot reconbot merged commit a3b8d35 into master Sep 24, 2017
@reconbot reconbot deleted the error-on-baudrate branch September 24, 2017 21:15
@codecov-io
Copy link

codecov-io commented Sep 24, 2017

Codecov Report

Merging #1347 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
+ Coverage   78.97%   79.02%   +0.04%     
==========================================
  Files          20       20              
  Lines         899      901       +2     
  Branches      164      165       +1     
==========================================
+ Hits          710      712       +2     
  Misses        189      189
Impacted Files Coverage Δ
lib/serialport.js 97.16% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c590021...9f83d47. Read the comment docs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants