Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialport Monorepo #1606

Closed
7 tasks done
reconbot opened this issue Jul 24, 2018 · 5 comments · Fixed by #1664
Closed
7 tasks done

Serialport Monorepo #1606

reconbot opened this issue Jul 24, 2018 · 5 comments · Fixed by #1664
Assignees
Labels
feature-request Feature or Enhancement
Milestone

Comments

@reconbot
Copy link
Member

reconbot commented Jul 24, 2018

I want to break out the bindings, terminal and other components into their own packages. I also want to fold the serialport-utils repo into this one as maintaining both isn't necessary. serialport-utils did prove out the lerna project structure for our parsers.

I propose the following features and packages

  • A single documentation site
  • serialport will always have everything and be very friendly users of this package shouldn't notice a change
  • @serialport/parser-* moved to this repo (maintaining history from serialport-utils as sordid as it might be since it used to be part of this repo)
  • @serialport/stream becomes the serialport.js stream interface that is most of this project
  • @serialport/binding-* become the platform specific binding packages (the challenge here is to figure out how to build individual bundled binaires and the auto download all os one)
  • @serialport/term becomes the terminal cli tool
  • @serialport/list becomes the serialport list cli tool
@reconbot reconbot self-assigned this Jul 24, 2018
@reconbot reconbot added the feature-request Feature or Enhancement label Jul 24, 2018
@mathieulj
Copy link

Just to chime in that I do see a use to this as I was just poking around exactly to see if I could pull in the API without all the dependencies for the CLI.

@reconbot
Copy link
Member Author

I got it working, but binary builds are ... gonna have to be figured out, this is going to work differently as prebuild expects different tags.

@reconbot
Copy link
Member Author

I built the needed features into prebuild to make it work with lerna style tags. Should be able to have this out once the PRs land. prebuild/prebuild#229

@reconbot
Copy link
Member Author

reconbot commented Aug 29, 2018

Builds aren't happening on tag push because https://developer.github.com/v3/activity/events/types/#createevent

Note: webhooks will not receive this event for created repositories. Additionally, webhooks will not receive this event for tags if more than three tags are pushed at once.

There's no guarantee there wont be more than thee packages published.

@reconbot
Copy link
Member Author

But when I do push less than or equal to 3 tags builds work great!

@reconbot reconbot added this to the Next milestone Aug 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Feature or Enhancement
Development

Successfully merging a pull request may close this issue.

2 participants