Removed PURGE_RXABORT flag on flush for Windows #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PURGE_RXABORT flag causes the ReadFileEx to be cancelled; on cancellation, the ReadIOCompletion method is called with a non-zero errorCode.
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
+ Coverage 64.84% 66.78% +1.94%
==========================================
Files 23 22 -1
Lines 876 834 -42
==========================================
- Hits 568 557 -11
+ Misses 308 277 -31
|
|
I hope this can merged soon, so I can resolve https://github.com/rfxcom/node-rfxcom/issues/81 |
|
Bump |
|
I'm curious what this does to the read in progress, however whatever that is is better than erroring out the port. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PURGE_RXABORT flag causes the ReadFileEx to be cancelled, which somehow causes the port to become disconnected (didn't dive that deep into the intricacies of the issue).
After creating this fix, we found issue #1013, which suggests the same resolution; after reviewing PR #1223, I'm not sure that #1013 was ever resolved correctly.
This resolves #1409.