Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing issue on Linux with v8.0.0 #1908

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Fix writing issue on Linux with v8.0.0 #1908

merged 1 commit into from
Aug 14, 2019

Conversation

icebob
Copy link
Contributor

@icebob icebob commented Aug 13, 2019

Hi,

there is an issue on Linux when writing to the serial port with new 8.0.0 version. It sends only one chunk and stops sending others. The problem is that the return value of writeAsync is changed and there is an unnecessary resolve in the unixWrite function. This PR fixes this issue. Tested on Linux ARM.

@reconbot
Copy link
Member

This was a silly mistake. Thank you for the fix.

@reconbot reconbot merged commit a7d1937 into serialport:master Aug 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants