feat: add end event for piping #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that if this functionality is introduced, it should be off by default and enabled by an option in the constructor params. Otherwise I would count it in a major version bump. |
|
We got a major release in beta, unsure what the default should be. Probably best to keep it the same as it is now even if it’s dissimilar to fs and net. |
|
Specifically because people seem to constantly open and close ports or they never close ports. |
This will allow streams to end. We haven't done this because it allows a stream to be reopened and data to be continued to be read. Adds `endOnClose` to stream options so the stream will emit the end event when the port is closed. This will signal any piped parsers to end as well. If the port is reopened the parsers won’t function.
reconbot
force-pushed
the
reconbot/end-event
branch
from
71c9376
to
2c20eef
Compare
|
How's this? |
|
Looks good to me. 👍 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow streams to end. We haven't done this because it allows a stream to be reopened and data to be continued to be read. This may not be a good idea but I'm opening this issue for discussion.
Maybe we should have this as an option?