Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slip decoder to parser-slip-encoder #2196

Merged
merged 1 commit into from
May 26, 2021

Conversation

doggkruse
Copy link
Contributor

@doggkruse doggkruse commented Jan 3, 2021

Add slip decoder to parser-slip-encoder
Add option to specify slip escape codes
Add optional start and start escape

Resolves #1608

…scape codes. Add optional start and start escape.
@reconbot
Copy link
Member

I like this a lot! It's a major breaking change which is why I haven't merged it in yet.

@doggkruse
Copy link
Contributor Author

I assume the breaking change is the new require structure? Is there a cleaner way to handle this?

@reconbot
Copy link
Member

Lets support both the default export and the named exports. That should be alright.

@reconbot reconbot self-requested a review February 23, 2021 02:04
@hrueger
Copy link

hrueger commented Apr 24, 2021

I just tried this and it works perfectly. Is there any way I can help to get this PR merged?

@reconbot
Copy link
Member

I'm just waiting for the change to the export so it's not a breaking change.

@hrueger
Copy link

hrueger commented May 25, 2021

I'd definitely help with this, but I don't have write access to @doggkruse's branch...

@reconbot reconbot merged commit 85297bc into serialport:master May 26, 2021
@reconbot
Copy link
Member

I'll fix it up. We need some docs for this on the website if either of you are willing or able.

@doggkruse
Copy link
Contributor Author

Thanks for getting this merged! I'm happy to update the docs for the website but not sure how to get started?

@doggkruse doggkruse deleted the slip-parser-decoder branch May 29, 2021 20:54
@reconbot
Copy link
Member

reconbot commented Jun 6, 2021

Hit the edit button on this page =) https://serialport.io/docs/api-parser-slip-encoder

lvogt pushed a commit to lvogt/node-serialport that referenced this pull request Aug 10, 2021
- Add option to specify slip escape codes
- Add optional start and start escape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Common Serial protocols: SLIP & PPP
3 participants