-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slip decoder to parser-slip-encoder #2196
Conversation
…scape codes. Add optional start and start escape.
I like this a lot! It's a major breaking change which is why I haven't merged it in yet. |
I assume the breaking change is the new require structure? Is there a cleaner way to handle this? |
Lets support both the default export and the named exports. That should be alright. |
I just tried this and it works perfectly. Is there any way I can help to get this PR merged? |
I'm just waiting for the change to the export so it's not a breaking change. |
I'd definitely help with this, but I don't have write access to @doggkruse's branch... |
I'll fix it up. We need some docs for this on the website if either of you are willing or able. |
Thanks for getting this merged! I'm happy to update the docs for the website but not sure how to get started? |
Hit the edit button on this page =) https://serialport.io/docs/api-parser-slip-encoder |
- Add option to specify slip escape codes - Add optional start and start escape
Add slip decoder to parser-slip-encoder
Add option to specify slip escape codes
Add optional start and start escape
Resolves #1608