Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider match_byte macro if plain match becomes optimized enough #128

Open
SimonSapin opened this issue Mar 13, 2017 · 3 comments
Open

Reconsider match_byte macro if plain match becomes optimized enough #128

SimonSapin opened this issue Mar 13, 2017 · 3 comments

Comments

@SimonSapin
Copy link
Member

@nox pointed out (#112 (comment)) that rust-lang/rust#39456 brings the same performance to plain match expressions.
@SimonSapin SimonSapin mentioned this issue Mar 13, 2017
Merged
@SimonSapin
Copy link
Member Author

1.17.0 is stable, but the tests::unquoted_url benchmark is ~2x slower when compiled with --features dummy_match_byte. CC @nox, @emilio

@nox
Copy link
Contributor

nox commented Jun 27, 2017

Sad!

@SimonSapin SimonSapin changed the title Remove match_byte macro when Rust 1.17 is stable. Reconsider match_byte macro if plain match becomes optimized enough May 8, 2023
@SimonSapin
Copy link
Member Author

Still a ~2x difference in 1.71

@SimonSapin SimonSapin mentioned this issue May 8, 2023
Merged
@emilio emilio mentioned this issue Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nox @SimonSapin