Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SOCKS5 state machine #3

Closed
sethmlarson opened this issue Sep 6, 2019 · 4 comments
Closed

Add support for SOCKS5 state machine #3

sethmlarson opened this issue Sep 6, 2019 · 4 comments

Comments

@sethmlarson
Copy link
Owner

We shouldn't be able to make requests before we're authenticated successfully.

@yeraydiazdiaz
Copy link
Collaborator

I came across https://github.com/glyph/automat some time ago, would it be a good fit?

It might be overkill if the state machine is simple though since h11 implemented its own.

@sethmlarson
Copy link
Owner Author

Eh, let's implement our own state machine, I think there's only a few states for TCP:

CLIENT_AUTH_REQUIRED
SERVER_AUTH_REPLY
CLIENT_AUTHENTICATED
TUNNEL_READY

Let's keep the states identical for SOCKS4 and SOCKS5 cuz 4 doesn't really have a state machine. :)

We'll have to figure out how to handle SOCKS5 UDP for HTTP/3.

@yeraydiazdiaz
Copy link
Collaborator

I believe this is covered now?

We'll have to figure out how to handle SOCKS5 UDP for HTTP/3.

UDP is addressed separately in #4

@sethmlarson
Copy link
Owner Author

Forgot to close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants