Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links inside the LTI open inside the LTI iframe #9

Open
oboratav opened this issue Jan 27, 2022 · 0 comments · May be fixed by #10
Open

Links inside the LTI open inside the LTI iframe #9

oboratav opened this issue Jan 27, 2022 · 0 comments · May be fixed by #10

Comments

@oboratav
Copy link

Hi! I'm an end-user of this LTI, and I noticed that hyperlinks inside the LTI (eg. instructor canvas profile link, the link to send a canvas message, etc.) use the iframe as their context because they don't have the target tag set. This leads to the target page loading inside of the iframe, which is not great in terms of usability. I came across this repo last night and figured I might as well create an issue 😂

Here's what it looks like:

Screenshot

More docs on the target tag: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-target

@oboratav oboratav linked a pull request Jan 27, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant