Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document/unify naming convention for repeated dimensions #284

Closed
tomwhite opened this issue Sep 28, 2020 · 2 comments · Fixed by #574
Closed

Document/unify naming convention for repeated dimensions #284

tomwhite opened this issue Sep 28, 2020 · 2 comments · Fixed by #574
Labels
documentation Improvements or additions to documentation
Milestone
0.3.0

Comments

@tomwhite
Copy link
Collaborator

In PC-relate we have sample_x and sample_y, whereas in Fst and divergence we have cohorts_0 and cohorts_1.
@tomwhite
Copy link
Collaborator Author

See #260

@hammer hammer added the documentation Improvements or additions to documentation label Oct 15, 2020
@hammer hammer added this to the 0.1.0 milestone Oct 15, 2020
@tomwhite tomwhite mentioned this issue May 18, 2021
Merged
@mergify mergify bot closed this as completed in #574 May 18, 2021
@tomwhite
Copy link
Collaborator Author

Related discussion: pydata/xarray#3731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Rename dimensions 'sample_x' and 'sample_y' in PC relate tomwhite/sgkit
2 participants
@hammer @tomwhite