Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement non-deletable hotkeys and addable hotkeys for certain hotkey functions #426

Closed
bhajneet opened this issue Feb 21, 2020 · 5 comments · Fixed by #548
Closed

Implement non-deletable hotkeys and addable hotkeys for certain hotkey functions #426

bhajneet opened this issue Feb 21, 2020 · 5 comments · Fixed by #548
Labels
Impacts Some Affects the average end-user. Scope: Frontend/Settings □ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

These two hotkeys should never be removable, but there could be extra hotkeys added for it.

Originally posted by @bhajneet in #425 (comment)

@bhajneet bhajneet added Impacts Some Affects the average end-user. Scope: Frontend/Settings Status: Complete □ Type Story Feature or requirement written from the user's perspective using non-technical language. labels Feb 21, 2020
@Harjot1Singh
Copy link
Member

any others?

@bhajneet
Copy link
Member Author

Probably arrow keys (though j and l can be removed I suppose)

I would think anything that is super core to the concept of using shabad os should not be configurable. Arrows, enter, hide controller, full screen. Maybe activities as well? /, y, b, g. I would think it odd if someone changed the esc key for clearing as well. These should remain "core" hotkeys that anyone who needs to use shabad os elsewhere can use.

What do you think?

@Harjot1Singh
Copy link
Member

I actually think that all hotkeys should be all be reassignable. You may wish to change the activate line hotkey to ., and I see nothing wrong with that.

The only ones that I think should be fixed are arrow up and down + enter in the controller, and that’s it, because they’re not really hotkeys

@bhajneet
Copy link
Member Author

I just don't want to go to a different gurdwara and not be able to use basic hotkeys. So whatever you want to define as basic hotkeys needed for the most basic functioning of shabad os with the controller hidden on a single-presentation display will work for me. I think those are ctrl+h, arrows, enter, esc, spacebar, and number 1 key/home key.

@bhajneet
Copy link
Member Author

This doesn't mean they can't add a hotkey "." to activate the line. It's not being used for any of the basic hotkeys so you can add that on to the enter hotkey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts Some Affects the average end-user. Scope: Frontend/Settings □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants