Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "disabled" copy button for bookmarks #497

Closed
bhajneet opened this issue May 8, 2020 · 1 comment · Fixed by #503
Closed

Show "disabled" copy button for bookmarks #497

bhajneet opened this issue May 8, 2020 · 1 comment · Fixed by #503
Assignees
@saihaj
Labels
Impacts Few Does not affect many end-users. Scope: Frontend/Controller ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@bhajneet
Copy link
Member

bhajneet commented May 8, 2020

Currently the button is missing and looks "broken". However, if this is by design we should "show" that by graying it out and not making it clickable
@bhajneet bhajneet added Status: Confirmed ○ Type Bug Regressions/production issues that do not function as intended. Impacts Few Does not affect many end-users. Scope: Frontend/Controller labels May 8, 2020
@bhajneet bhajneet mentioned this issue May 8, 2020
Open
@saihaj
Copy link
Member

saihaj commented May 8, 2020 •
edited
Loading

This is not broken. Right now it is only suppose to show for shabads and no bani's and the way bookmarks work anything in it is considered as bani so that is why there is no "Copy" Button

saihaj added a commit to saihaj/ShabadOSpresenter that referenced this issue May 8, 2020
@saihaj
fix(frontend/controller): show dsiabled copy button
869a0f9 
Also refactors CSS for popover panel buttons.

Fixes shabados#497
saihaj added a commit to saihaj/ShabadOSpresenter that referenced this issue May 8, 2020
@saihaj
fix(frontend/controller): show disabled copy button
5a57a08 
Also refactors CSS for popover panel buttons.

Fixes shabados#497
@saihaj saihaj mentioned this issue May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saihaj saihaj

Labels
Impacts Few Does not affect many end-users. Scope: Frontend/Controller ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI Fixes saihaj/ShabadOSpresenter
2 participants
@bhajneet @saihaj