Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate styling #546

Open
Harjot1Singh opened this issue May 23, 2020 · 2 comments
Open

Consolidate styling #546

Harjot1Singh opened this issue May 23, 2020 · 2 comments
Labels
Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. Impacts Some Affects the average end-user. Scope: Frontend/Controller Scope: Frontend/Settings Scope: Frontend/Themes

Comments

@Harjot1Singh
Copy link
Member

Is your feature request related to a problem? Please describe.
Common Material UI components are being styled at the local component level. This means that for every dialog we make, we have to restyle it with the same properties. It also means that we make more mistakes when it comes to regression and ensuring our theme has full coverage in our app.

Describe the solution you'd like
Global application of Material UI styles, using the themes.

Describe alternatives you've considered

  • Continuing the same way: yuck
  • CSS-in-JS: too big a migration effort and would require us to change our theme format yet again. But it does allow us to parse themes properly etc.

Additional context
We have a lot of these component styles defined in SettingsComponent.css.

@Harjot1Singh Harjot1Singh added Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. Impacts Some Affects the average end-user. Scope: Frontend/Settings Scope: Frontend/Controller Scope: Frontend/Themes Status: To Do labels May 23, 2020
@saihaj
Copy link
Member

saihaj commented May 28, 2020

Please also see https://cssinjs.org/?v=v10.1.1, which i've used succesfully in other projects btw, this is lit. Think it's the way forward, but not a priority rn. It'd help us from having to style each thing individually
View in Slack

@saihaj
Copy link
Member

saihaj commented Jun 28, 2020

I think in the future, we should start thinking about bundling up our own component library/UI presets etc.
shabados/theme-tool#47 (review)

We can get rid of MaterialUI all together and just use CSS-in-JS with ShabadOS-styles lib since it will be helpful for website redesign and other projects (DB viewer, theme tool, connect and future projects)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort 5 Chunky! Ensure this is the smallest that it can be split to before committing to it. Impacts Some Affects the average end-user. Scope: Frontend/Controller Scope: Frontend/Settings Scope: Frontend/Themes
Projects
Status: Triage
Development

No branches or pull requests

3 participants