Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get line data given line ID #596

Open
saihaj opened this issue Jul 21, 2020 · 0 comments
Open

Get line data given line ID #596

saihaj opened this issue Jul 21, 2020 · 0 comments
Assignees
Labels
Scope: Backend Scope: Frontend/Controller ✓ Type Task Technical work that is not directly related to a user requirement but still must be completed.

Comments

@saihaj
Copy link
Member

saihaj commented Jul 21, 2020

Currently we have custom hooks that get us current line data from the context. But the problem is when we want a specific line from line ID which is required to resolve #235, #511 we can't really get it without hurting performance. Solution that I can think is:

  • Add an action in controller that does this but we will be querying so much and not good for performance.
  • In case of Add copy from selected line vs from what's active on presenter #511, if I fetch all the data to fulfill the shape I want so that I can run it through our in copy hotkeys we overfetch for the users who don't even use this at all or someone who just uses it once.

Solution: Some magical function that returns something like this (so it is consistent what we have rn) but also not affecting performance.
image

@saihaj saihaj added ? Type Question User/developer question. Scope: Backend Scope: Frontend/Controller ϟ Type Epic Describing a big goal. A collection of issues. Should never end up in an iteration. and removed ? Type Question User/developer question. labels Jul 21, 2020
@saihaj saihaj moved this to Triage in Project Management Oct 24, 2021
@bhajneet bhajneet added ✓ Type Task Technical work that is not directly related to a user requirement but still must be completed. and removed ϟ Type Epic Describing a big goal. A collection of issues. Should never end up in an iteration. labels Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Scope: Frontend/Controller ✓ Type Task Technical work that is not directly related to a user requirement but still must be completed.
Projects
Status: Triage
Development

No branches or pull requests

3 participants