Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys v3 #693

Open
bhajneet opened this issue Sep 8, 2024 · 0 comments
Open

Hotkeys v3 #693

bhajneet opened this issue Sep 8, 2024 · 0 comments
Labels
✓ Type Task Technical work that is not directly related to a user requirement but still must be completed.
Milestone

Comments

@bhajneet
Copy link
Member

bhajneet commented Sep 8, 2024

Summary

WIP

Hotkeys are also going to have breaking changes:

  • Remove most modifiers (ctrl, alt, cmd) as it's caused year long issues with windows + mac, but also because it's harder and the friction isn't required
  • To do this we have to remove the number hotkeys used to jump to a specific line. We will instead use it to jump to specific "chapters" in the navigator (1 is first pauri, 2 is second, r is rahao, ` is the manglacharan before the first pauri if any, 9 is the last pauri regardless of how many there are, 0 is last line, etc...)
  • option + left and right on mac will seek "chapters" (if in the middle and going left return to beginning, similar to next and previous track on music players)

What are "chapters"? In akv it would be the beginning of every salok and pauri. In a typically read/sung shabad it would be each pauri and rahao. Seeking "chapters" does not skip over rahao. If someone is reading akv it makes re-reading the pauri easier (from the last line you would seek to the beginning of the chapter again). This also makes it easier during an anand karaj when they read the laavan's first line again at the end of each pauri. Seeking chapters is similar to using the spacebar today, but easier to predict/reason about as you're deterministic about the direction.

Approach

@bhajneet bhajneet added the ✓ Type Task Technical work that is not directly related to a user requirement but still must be completed. label Sep 8, 2024
@Harjot1Singh Harjot1Singh added this to the V3 - Required milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✓ Type Task Technical work that is not directly related to a user requirement but still must be completed.
Projects
None yet
Development

No branches or pull requests

2 participants