Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chromeos): Fix compatibility with new deps and new ChromeOS #89

Merged
merged 1 commit into from
May 15, 2024
Merged

fix(chromeos): Fix compatibility with new deps and new ChromeOS #89

merged 1 commit into from
May 15, 2024

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented May 15, 2024 •
edited
Loading

  • Update CrOS private key URL (branch name "master" => "main")
  • Fix private key permissions (0600)
  • Fix node-ssh usage ("privateKey" => "privateKeyPath", exit code "null" => "0")
  • Move shell scripts into "scripts" folder (cleanup)
  • Fix Chrome launch arguments for compatibility with Lacros

@joeyparrish
fix(chromeos): Fix compatibility with new deps and new ChromeOS
504e1b3 
 - Update CrOS private key URL (branch name "master" => "main")
 - Fix private key permissions
 - Fix node-ssh usage ("privateKey" => "privateKeyPath",
                       exit code "null" => "0")
 - Move shell scripts into "scripts" folder (cleanup)
 - Fix Chrome launch arguments for compatibility with LaCros
@joeyparrish joeyparrish merged commit 47c244e into shaka-project:main May 15, 2024
16 checks passed
@joeyparrish joeyparrish deleted the chromeos branch May 15, 2024 20:31
@github-actions github-actions bot mentioned this pull request May 15, 2024
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alekzz alekzz alekzz approved these changes

@avelad avelad Awaiting requested review from avelad

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyparrish @alekzz