feat(chromecast)!: Fork receiver app v1 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prepare for a v2 client and receiver app, this copies receiver.html (with some additional comments) to receiver-v1.html. After merging this change, the registration for the v1 receiver app ID will be changed to point to receiver-v1.html. This will free us to make breaking changes in receiver.html under a new app ID.
joeyparrish
changed the title
alekzz
approved these changes
May 17, 2024
|
No, git will always see it as a new file. However, the overall history is still preserved. You can see the development of v1 over time in receiver.html's history. |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for a v2 client and receiver app, this copies receiver.html (with some additional comments) to receiver-v1.html. After merging this change, the registration for the v1 receiver app ID will be changed to point to receiver-v1.html. This will free us to make breaking changes in receiver.html under a new app ID.
It is important for a smooth transition to make a copy of receiver.html first and not simply rename it, because there will be a transition period where some Chromecasts under test will still refer to the old URL. This should be < 48 hours after merge.