Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building with Ninja on MacOSX #65

Closed
nevil opened this issue Jan 20, 2016 · 3 comments
Closed

Support building with Ninja on MacOSX #65

nevil opened this issue Jan 20, 2016 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request

Comments

@nevil
Copy link
Contributor

nevil commented Jan 20, 2016

It would be convenient to have support for building on MacOSX.
Xcode support is not necessary. Supporting Ninja is enough.
@nevil
Copy link
Contributor Author

nevil commented Jan 20, 2016

Being worked on in #66

@kqyang
Copy link
Contributor

kqyang commented Jan 20, 2016

Hey nevil, thanks for supporting edash-packager and improving this project! The changes look good to me, with just a couple of nits.

@kqyang kqyang added the type: enhancement New feature or request label Jan 20, 2016
@kqyang
Copy link
Contributor

kqyang commented Jan 23, 2016

I have merged the pull request.
@nevil thanks for your work on MacOSX and thanks for the contribution to edash-packager project!

@kqyang kqyang closed this as completed Jan 23, 2016
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 19, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nevil @kqyang @shaka-bot