From 12451444dabe099413817eb31db6436cbbd8c907 Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Mon, 25 Apr 2022 13:29:03 -0700 Subject: [PATCH] ci: Fix appspot subdomain computation (#4153) We should replace all dots with dashes, not just the first one. --- .github/workflows/release-please.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-please.yaml b/.github/workflows/release-please.yaml index f910a2e2ad..f6bf944eb8 100644 --- a/.github/workflows/release-please.yaml +++ b/.github/workflows/release-please.yaml @@ -110,7 +110,7 @@ jobs: run: | # This is the same as the version tag, but with dots replaced by # dashes. For example, v3.2.2 would have the subdomain v3-2-2. - APPSPOT_SUBDOMAIN=$( echo ${{ needs.release.outputs.tag_name }} | sed -e 's/\./-/' ) + APPSPOT_SUBDOMAIN=$( echo ${{ needs.release.outputs.tag_name }} | sed -e 's/\./-/g' ) echo APPSPOT_SUBDOMAIN=$APPSPOT_SUBDOMAIN >> $GITHUB_ENV # "Promoting" an appspot deployment makes it the default which shows