From 1e8308058cdfa9745dbd2ac37e427d89db0f6849 Mon Sep 17 00:00:00 2001 From: Raymond Cheng Date: Fri, 3 Jun 2022 23:17:22 -0700 Subject: [PATCH] fix: Remove IE 11 from default browsers for Windows (#4272) IE 11 has not been supported since v3.1, so developers following CONTRIBUTING.md should not see tests fail due to the continued inclusion of IE. Removed IE from the default list of browsers for Windows. Anybody who still needs to test against IE can explicitly test via python build/test.py --browsers IE. Closes #4271 --- AUTHORS | 1 + CONTRIBUTORS | 1 + build/test.py | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 7f65582102..68f95f3f49 100644 --- a/AUTHORS +++ b/AUTHORS @@ -79,3 +79,4 @@ Verizon Digital Media Services <*@verizondigitalmedia.com> ViacomCBS <*@viacomcbs.com> Vincent Valot Wayne Morgan +Raymond Cheng diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 26c5952226..c586721469 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -116,3 +116,4 @@ Vignesh Venkatasubramanian Vincent Valot Wayne Morgan Yohann Connell +Raymond Cheng diff --git a/build/test.py b/build/test.py index 2781f242a0..047f40eb96 100755 --- a/build/test.py +++ b/build/test.py @@ -104,7 +104,7 @@ def _GetDefaultBrowsers(): return ['Chrome','Edge','Firefox','Safari'] if shakaBuildHelpers.is_windows() or shakaBuildHelpers.is_cygwin(): - return ['Chrome','Edge','Firefox','IE'] + return ['Chrome','Edge','Firefox'] raise Error('Unrecognized system: %s' % platform.uname()[0])