From 958512e9aed3e7ef649724ba1d0647084175fa6f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?A=CC=81lvaro=20Velad=20Galva=CC=81n?= <ladvan91@hotmail.com>
Date: Thu, 5 Sep 2024 11:09:11 +0200
Subject: [PATCH] feat(DASH): Disable xlink processing by default

---
 demo/common/assets.js            | 9 ++++++++-
 externs/shaka/player.js          | 2 +-
 lib/util/player_configuration.js | 2 +-
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/demo/common/assets.js b/demo/common/assets.js
index 38551869ceb..2e4f0c7cf3f 100644
--- a/demo/common/assets.js
+++ b/demo/common/assets.js
@@ -578,7 +578,14 @@ shakaAssets.testAssets = [
       .addFeature(shakaAssets.Feature.MP4)
       .addFeature(shakaAssets.Feature.WEBM)
       .addFeature(shakaAssets.Feature.XLINK)
-      .addFeature(shakaAssets.Feature.OFFLINE),
+      .addFeature(shakaAssets.Feature.OFFLINE)
+      .setExtraConfig({
+        manifest: {
+          dash: {
+            disableXlinkProcessing: false,
+          }
+        },
+      }),
   // From: http://dig.ccmixter.org/files/JeffSpeed68/53327
   // Licensed under Creative Commons BY-NC 3.0.
   // Free for non-commercial use with attribution.
diff --git a/externs/shaka/player.js b/externs/shaka/player.js
index 17d988cc467..b977d37883c 100644
--- a/externs/shaka/player.js
+++ b/externs/shaka/player.js
@@ -1096,7 +1096,7 @@ shaka.extern.xml.Node;
  * @property {boolean} disableXlinkProcessing
  *   If true, xlink-related processing will be disabled.
  *   <br>
- *   Defaults to <code>false</code>.
+ *   Defaults to <code>true</code>.
  * @property {boolean} xlinkFailGracefully
  *   If true, xlink-related errors will result in a fallback to the tag's
  *   existing contents. If false, xlink-related errors will be propagated
diff --git a/lib/util/player_configuration.js b/lib/util/player_configuration.js
index 3f26ef5aeb9..9e60c0a686c 100644
--- a/lib/util/player_configuration.js
+++ b/lib/util/player_configuration.js
@@ -124,7 +124,7 @@ shaka.util.PlayerConfiguration = class {
       dash: {
         clockSyncUri: '',
         ignoreDrmInfo: false,
-        disableXlinkProcessing: false,
+        disableXlinkProcessing: true,
         xlinkFailGracefully: false,
         ignoreMinBufferTime: false,
         autoCorrectDrift: true,