Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5 Master -- Playback skips first period of VOD asset #1601

Closed
TheJohnBowers opened this issue Sep 27, 2018 · 3 comments
Closed

2.5 Master -- Playback skips first period of VOD asset #1601

TheJohnBowers opened this issue Sep 27, 2018 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@TheJohnBowers
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?:
Yes, I don't see anything. I hope I haven't missed something.
What version of Shaka Player are you using?:
2.5 Master
Can you reproduce the issue with our latest release version?:
No
Can you reproduce the issue with the latest code from master?:
Yes
Are you using the demo app or your own custom app?:
Demo App
If custom app, can you reproduce the issue using our demo app?:
NA
What browser and OS are you using?:
Chrome macos
What are the manifest and license server URIs?:
https://content.downlynk.com/88ec75470b1a48efbe943986c4517be2.mpd?ad=superbowl&prettydash=1
https://content.downlynk.com/wv
What did you do?
Playback from 2.4.x and earlier does not skip the first period. Playback from master updated yesterday does skip the first period. Nothing interesting or informative is logged in the console.
What did you expect to happen?
Not skipping the first period.
What actually happened?
First Period was skipped.

@michellezhuogg
Copy link
Contributor

Found that Latest nightly build skips the first period while v2.4.4 doesn't. Will work on fixing this.

@michellezhuogg michellezhuogg added type: bug Something isn't working correctly and removed needs triage labels Oct 1, 2018
@shaka-bot shaka-bot added this to the v2.5 milestone Oct 1, 2018
@vaage
Copy link
Contributor

vaage commented Nov 5, 2018

I only just started looking into this...

My high-level findings so far:

  • The difference between 2.4 and 2.5 is in what Playhead is saying our start time is.

Low-level findings:

  • Playhead gets the start time from PresentationTimeline
  • PresentationTimeline determines the start time from minSegmentStartTime_
  • minSegmentStartTime_ which is updated from notifySegments
  • notifySegments is called via SegmentList/SegmentTemplate/SegmentBase by DashParser

A more accurate problem statement:

  • SegmentTemplate is not updating minSegmentStartTime_ when the segments have a known duration

I will sync-up with the Shaka Player team internally to determine next steps.

@ismena ismena assigned ismena and unassigned vaage Nov 6, 2018
@joeyparrish
Copy link
Member

Fix released in v2.5.0-beta2.

@shaka-project shaka-project locked and limited conversation to collaborators Jan 6, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

6 participants