Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSSH parser ignores box version #19

Closed
joeyparrish opened this issue Jan 28, 2015 · 1 comment
Closed

PSSH parser ignores box version #19

joeyparrish opened this issue Jan 28, 2015 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

The PSSH parser in lib/util/pssh.js should skip any box with an unrecognized version number. It should skip the entire box, not the data payload.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 28, 2015
@joeyparrish joeyparrish self-assigned this Jan 28, 2015
@joeyparrish joeyparrish added this to the v1.2 milestone Jan 28, 2015
@joeyparrish
Copy link
Member Author

From ISO 23001-7 2nd edition:


aligned(8) class ProtectionSystemSpecificHeaderBox extends FullBox(‘pssh’, version, flags=0)
{
  unsigned int(8)[16] SystemID;
  if (version > 0) {
    unsigned int(32) KID_count;
    {
      unsigned int(8)[16] KID; 
    } [KID_count];
  }
  unsigned int(32) DataSize;
  unsigned int(8)[DataSize] Data; 
}

The generic CENC PSSH box is specified as requiring version=1 (see http://www.w3.org/TR/encrypted-media/cenc-format.html section 4)

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants