Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTML empty line in between cues #2762

Closed
mattiaspalmgren opened this issue Jul 30, 2020 · 1 comment
Closed

TTML empty line in between cues #2762

mattiaspalmgren opened this issue Jul 30, 2020 · 1 comment
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@mattiaspalmgren
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
2.5.12 and 3.2.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Custom app, where I've just implemented the basic usage example.

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Chrome, MacOs, Catalina

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
N/A

What did you do?

We've a TTML caption formatted as:

<div>
    <p begin="00:00:01.800" end="696:15:11.521" xml:id="s0" region="r" style="p">
        <span style="style1">Hej, lilla gumman.</span>
        <br/>
        <span style="style2">– Vilket fint italienskt hus ni har!</span>
    </p>
</div>

What did you expect to happen?
That it should render two caption lines, with no empty line in between.

What actually happened?
See attached image., it renders three lines, with an empty line in between from the <br/> tag.

I haven't been able to understand from the spec what should happen in this scenario and if the formatting is wrong, but I can see that dash.js, rx-player and the IMSC1 Renderer (which I'm not familiar with but saw it linked in another issue) renders the captions without the line in between.

image

What do you think?

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI and removed needs triage labels Jul 30, 2020
@joeyparrish
Copy link
Member

You are correct. I'm working on other TTML parsing and rendering fixes, so I'll work on this, too. Thanks for filing!

@shaka-bot shaka-bot added this to the v3.1 milestone Jul 30, 2020
@joeyparrish joeyparrish self-assigned this Jul 30, 2020
@shaka-project shaka-project locked and limited conversation to collaborators Oct 10, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants