-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(demo): allow switch between UITextDisplayer and SimpleTextDisplayer #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
Something isn't working correctly
component: demo page
The issue is in the demo page; does not affect production applications
component: captions/subtitles
The issue involves captions or subtitles
labels
Jun 7, 2022
theodab
approved these changes
Jun 7, 2022
Lines 1163 to 1173 in 8719bdc
Yeah, it looks like the demo config values are applied to the player inside |
avelad
pushed a commit
to avelad/shaka-player
that referenced
this pull request
Jun 8, 2022
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2022
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2022
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Jun 14, 2022
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: captions/subtitles
The issue involves captions or subtitles
component: demo page
The issue is in the demo page; does not affect production applications
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4209