-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS/TS multi-audio A/V sync #4599
Comments
Thank you for the report. We'll look into it! |
Possible duplicate of #4589 |
Hi! Is there any update on this issue? Regarding your last comment @joeyparrish, we do not think this is exactly a duplicate of that issue, because in our case there is no need of any ad break, the issue is always there. You can see we are emitting an HLS stream correctly formed in this URL, and the desynchronization can be seen in any version of shaka player that includes the commit 36d0b54. |
For whatever reason, it looks like some of the changes from 89409ce (the PR that should be responsible for A/V sync after 36d0b54) were undone. I believe there must have been a problem when merging with 47fa309, which also changes the logic behind appending buffers. |
Okay, I think I was wrong in my previous statement. I had forgotten about 314a987, which changed how I did a git bisect, and I think the actual problem is #4338. That's where I'll have to sign off on this for now. I'll be going on break after today. |
Taking over for @theodab. Upgrading to P0, hoping to fix this by the end of the week (which is the end of the year given holidays). |
It's time-consuming to bisect this issue, because ad breaks tend not to have visible speech, and use voiceovers or on-screen titles instead. (Presumably because these are easier to localize and run across regions.) |
And some programs are dubbed foreign TV shows. 😢 I'm frequently unable to accurately judge lip sync on this content. But what I've seen so far is that I can't tell any difference between any combination of So I'm analyzing the segments for now instead. I'm checking to see if the contents of the TS segments agree with the metadata in the HLS playlists. Playlists all state that segments are exactly 6 seconds long, and |
Presentation timestamps in the media do not agree with PROGRAM-DATE-TIME metadata. For example:
Actual PTS: 7803148816
Actual PTS: 7803561136 The 7803561136 - 7803148816 = 412320 As far as I can tell, inaccuracy in the playlist's The reason v3 played this content is because we used a much higher-latency startup process to extract timestamps from media instead of MSE sequence mode, and we used that extracted timestamp information instead of @rauldelperal, can you confirm my findings? Lowering priority, tentatively marking this as bad content. I will prioritize #4589 now (previously suspected of being a duplicate), in case there is a separate AV sync issue there. |
Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including |
Have you read the FAQ and checked for duplicate open issues?
Yes
What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=es-ES;textlang=es-ES;uilang=es-ES;panel=CUSTOM%20CONTENT;build=uncompiled
https://shaka-player-demo.appspot.com/demo/#audiolang=es-ES;textlang=es-ES;uilang=es-ES;asset=https://directes-test.ccma.cat/live-origin/tv3-hls/master.m3u8;panel=CUSTOM%20CONTENT;build=uncompiled
What version of Shaka Player are you using?
v4.2.2-uncompiled
What browser and OS are you using?
"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36"
What did you do?
We don´t have added any changes on our side. We use the same Encoder version.
Since you have added to your v4 releases the commit "36d0b54" there is an A/V sync error playing an HLS/TS Multi-audio Livestream through Shaka-Player v4.X.X. If you try with older versions, this error does not appears.
What did you expect to happen?
Shaka-player should be able to A/V sync these type of HLS/TS Live Streams like others players do.
What actually happened?
An a clear A/V sync error.
The text was updated successfully, but these errors were encountered: