Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback stops with bad cue times on IE/Edge #501

Closed
joeyparrish opened this issue Aug 30, 2016 · 1 comment
Closed

Playback stops with bad cue times on IE/Edge #501

joeyparrish opened this issue Aug 30, 2016 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

@baseballbrad3 reports in #312 (comment):

We have some poorly formatted subtitles that would appear to have the same start and end times (or a duration of zero). When IE/Edge try to create a new TextTrackCue, the object creation throws an exception of "Syntax Error" and halts all playback.

Now, we certainly are to blame for the malformed VTT track, but I was wondering if it'd make sense to check that end > start prior to creation of the Cue.

We'd absolutely like to fix them, and (long term) we plan to, but unfortunately for us, it's difficult to go back and fix them.

From a user's perspective, if a video was unplayable, I'd be pretty upset. If a line here and there were dropped from the subtitles, I'd be a bit confused but would be less impacted. Certainly having some log messages when the subtitle is loaded would help identify the problem when a complaint came in.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Aug 30, 2016
@joeyparrish joeyparrish added this to the v2.0.0 milestone Aug 30, 2016
@joeyparrish joeyparrish self-assigned this Aug 30, 2016
@joeyparrish
Copy link
Member Author

@baseballbrad3, this has been verified via integration tests running on IE11. Let us know if there are any issues with this change in your own app.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants