fix: Fix uncaught global OBJECT_DESTROYED errors #6460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
avelad
approved these changes
Apr 19, 2024
joeyparrish
force-pushed
the
fix-object-destroyed-errors
branch
from
148e290
to
ed00bea
Compare
|
Incremental code coverage: 100.00% |
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Apr 19, 2024
The tests for MediaSourceEngine codec switching were written to ignore types and suppress access controls. The were unreadable, too, with very little whitespace, confusing one-letter variable names, and difficult-to-follow event mocking. This made it more difficult to debug test failures in PR shaka-project#6460. This rewrites the tests in a more readable manner with compiler enforcement of types in the tests. Two helper functions are used to isolate the necessary access-control suppressions. This exposed a bug in the tests, in which one test case (preserve SourceBuffer attributes) only passed because the original version failed to await on an async process. I am not sure that the functionality in that test exists at that level. For now, the test is disabled. I'll follow up with removal after more investigation. Related to shaka-project#6458, shaka-project#6460
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Apr 19, 2024
The tests for MediaSourceEngine codec switching were written to ignore types and suppress access controls. The were unreadable, too, with very little whitespace, confusing one-letter variable names, and difficult-to-follow event mocking. This made it more difficult to debug test failures in PR shaka-project#6460. This rewrites the tests in a more readable manner with compiler enforcement of types in the tests. Two helper functions are used to isolate the necessary access-control suppressions. This exposed a bug in the tests, in which one test case (preserve SourceBuffer attributes) only passed because the original version failed to await on an async process. I am not sure that the functionality in that test exists at that level. For now, the test is disabled. I'll follow up with removal after more investigation. Related to shaka-project#6458, shaka-project#6460
avelad
pushed a commit
that referenced
this pull request
Apr 22, 2024
The tests for MediaSourceEngine codec switching were written to ignore types and suppress access controls. The were unreadable, too, with very little whitespace, confusing one-letter variable names, and difficult-to-follow event mocking. This made it more difficult to debug test failures in PR #6460. This rewrites the tests in a more readable manner with compiler enforcement of types in the tests. Two helper functions are used to isolate the necessary access-control suppressions. This exposed a bug in the tests, in which one test case (preserve SourceBuffer attributes) only passed because the original version failed to await on an async process. I am not sure that the functionality in that test exists at that level. For now, the test is disabled. I'll follow up with removal after more investigation. Related to #6458, #6460
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
The tests for MediaSourceEngine codec switching were written to ignore types and suppress access controls. The were unreadable, too, with very little whitespace, confusing one-letter variable names, and difficult-to-follow event mocking. This made it more difficult to debug test failures in PR #6460. This rewrites the tests in a more readable manner with compiler enforcement of types in the tests. Two helper functions are used to isolate the necessary access-control suppressions. This exposed a bug in the tests, in which one test case (preserve SourceBuffer attributes) only passed because the original version failed to await on an async process. I am not sure that the functionality in that test exists at that level. For now, the test is disabled. I'll follow up with removal after more investigation. Related to #6458, #6460
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
The tests for MediaSourceEngine codec switching were written to ignore types and suppress access controls. The were unreadable, too, with very little whitespace, confusing one-letter variable names, and difficult-to-follow event mocking. This made it more difficult to debug test failures in PR #6460. This rewrites the tests in a more readable manner with compiler enforcement of types in the tests. Two helper functions are used to isolate the necessary access-control suppressions. This exposed a bug in the tests, in which one test case (preserve SourceBuffer attributes) only passed because the original version failed to await on an async process. I am not sure that the functionality in that test exists at that level. For now, the test is disabled. I'll follow up with removal after more investigation. Related to #6458, #6460
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6458