Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't update captions when video is paused #6474

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 24, 2024

This avoids wasting processing resources when it is not necessary

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Apr 24, 2024
@avelad avelad added this to the v4.8 milestone Apr 24, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 83.33%

@avelad avelad merged commit 2f653f1 into shaka-project:main Apr 24, 2024
22 checks passed
@avelad avelad deleted the ui-text-displayer-update branch April 24, 2024 15:27
joeyparrish pushed a commit that referenced this pull request May 7, 2024
This avoids wasting processing resources when it is not necessary
joeyparrish pushed a commit that referenced this pull request May 7, 2024
This avoids wasting processing resources when it is not necessary
joeyparrish pushed a commit that referenced this pull request May 7, 2024
This avoids wasting processing resources when it is not necessary
joeyparrish pushed a commit that referenced this pull request May 7, 2024
This avoids wasting processing resources when it is not necessary
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 23, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants