fix(DASH): Evict empty indexes in MetaSegmentIndex #7272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodab
added
the
component: DASH
|
This is not extensively tested. I plan on doing some more practical testing later, and maybe writing a new unit test. |
|
Incremental code coverage: 94.12% |
tykus160
reviewed
Sep 9, 2024
avelad
added
type: bug
tykus160
reviewed
Sep 10, 2024
tykus160
reviewed
Sep 10, 2024
tykus160
reviewed
Sep 10, 2024
Comment on lines
+2506
to
+2509
| const segmentIndex = mediaState.stream.segmentIndex; | ||
| if (segmentIndex instanceof shaka.media.MetaSegmentIndex) { | ||
| segmentIndex.evictEmpty(); | ||
| } |
There was a problem hiding this comment.
Did you move it here due to performance reasons?
There was a problem hiding this comment.
The initial revision of this PR I put together in a hurry before lunch, and didn't get a good chance to test it for more than a minute or two. It turned out the place I was calling evictEmpty originally was just the wrong function, it wasn't being called often enough.
tykus160
reviewed
Sep 11, 2024
tykus160
approved these changes
Sep 11, 2024
avelad
added a commit
that referenced
this pull request
Sep 11, 2024
Issue #6239 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad
added a commit
that referenced
this pull request
Sep 11, 2024
Issue #6239 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
joeyparrish
pushed a commit
that referenced
this pull request
Sep 13, 2024
Issue #6239 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6239