Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Clone closedCaptions map in PeriodCombiner output stream #7309

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(DASH): Clone closedCaptions map in PeriodCombiner output stream #7309

merged 1 commit into from
Sep 13, 2024

Conversation

tykus160
Copy link
Member

Fixes #7303

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Sep 13, 2024
@avelad avelad added this to the v4.12 milestone Sep 13, 2024
@avelad
Copy link
Member

avelad commented Sep 13, 2024

@Iragne Does it fix your issue?

@jeanalexandre-iragne-deltatre
Copy link

Thanks happy to test it

@avelad avelad self-requested a review September 13, 2024 14:42
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@Iragne
Copy link
Contributor

Iragne commented Sep 13, 2024

@Iragne Does it fix your issue?

I'm on it

joeyparrish
joeyparrish approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we can wait for confirmation of the fix before merging.

@Iragne
Copy link
Contributor

Iragne commented Sep 13, 2024

@joeyparrish i need 1h sorry guys

@Iragne
Copy link
Contributor

Iragne commented Sep 13, 2024

@joeyparrish all good on my side thanks a lot team

@joeyparrish joeyparrish merged commit 873bb24 into shaka-project:main Sep 13, 2024
18 of 19 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Open
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
@tykus160 @joeyparrish
fix(DASH): Clone closedCaptions map in PeriodCombiner output stream (#…
9a022aa 
…7309)

Fixes #7303
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
@tykus160 @joeyparrish
fix(DASH): Clone closedCaptions map in PeriodCombiner output stream (#…
5eff3d9 
…7309)

Fixes #7303
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Sep 13, 2024
@tykus160 @joeyparrish
fix(DASH): Clone closedCaptions map in PeriodCombiner output stream (#…
f3ce960 
…7309)

Fixes #7303
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2024
Merged
@tykus160 tykus160 deleted the wt-period-cc branch October 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.

DASH multi period generateVideoKey_ is not stable with close caption
6 participants
@tykus160 @avelad @jeanalexandre-iragne-deltatre @shaka-bot @Iragne @joeyparrish