Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'bufferingStart' should always fire during start-up. #77

Closed
tdrews opened this issue May 6, 2015 · 4 comments
Closed

'bufferingStart' should always fire during start-up. #77

tdrews opened this issue May 6, 2015 · 4 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: question A question from the community
Milestone

Comments

@tdrews
Copy link
Contributor

tdrews commented May 6, 2015

If the video is paused then a 'bufferingStart' event will not fire. This means that if autoplay=false then an initial 'bufferingStart' event may not fire. It is desirable if buffering events fired regardless of whether the video is paused or not.

@tdrews tdrews added type: bug Something isn't working correctly medium? labels May 6, 2015
@tdrews tdrews added this to the v1.3.1 milestone May 6, 2015
@joeyparrish
Copy link
Member

See also #63

@joeyparrish joeyparrish removed type: bug Something isn't working correctly medium? labels May 22, 2015
@joeyparrish
Copy link
Member

@sanbornhnewyyz, it seems to me that this is working as it should already. Here are the cases I tested:

Create a player, do not load anything, and delay 2 seconds.
Create a player, load with autoplay true, and wait for the first frame to play.
Create a player, load with autoplay true, pause, and delay 2 seconds.
Create a player, load with autoplay false, and delay 2 seconds.

In all of these cases, no bufferingStart event is fired and bufferingHistory.length is 0. Do you think this should be otherwise? It was originally my intent for this event to fire when the content underruns, but I could be convinced that the initial buffering should count as well.

@joeyparrish joeyparrish removed this from the v1.3.1 milestone May 22, 2015
@joeyparrish joeyparrish self-assigned this May 22, 2015
@joeyparrish joeyparrish added the type: question A question from the community label May 22, 2015
@joeyparrish
Copy link
Member

@sanbornhnewyyz: ping!

@joeyparrish joeyparrish added this to the v1.4.0 milestone Jun 9, 2015
@joeyparrish
Copy link
Member

@sanbornhnewyyz: I added some new integration tests to ensure that we are being consistent with the bufferingStart event. Please reopen if you feel that the use of bufferingStart is incorrect.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: question A question from the community
Projects
None yet
Development

No branches or pull requests

4 participants