Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running react_on_rails:install is not compatible with Shakapacker v8 #1625

Closed
timkrins opened this issue May 28, 2024 · 2 comments
Closed

Running react_on_rails:install is not compatible with Shakapacker v8 #1625

timkrins opened this issue May 28, 2024 · 2 comments

Comments

@timkrins
Copy link

Environment

  1. Ruby version: 3.3.0
  2. Rails version: 7.1.3.3
  3. Shakapacker/Webpacker version: 8.0.0
  4. React on Rails version: 14.0.1

Expected behavior

I set up a new Rails project.
I follow the installation guide for shakapacker, and then follow the Getting Started directions for react_on_rails.
The command rails generate react_on_rails:install installs the correct files required for this version of Shakapacker.

Actual behavior

I set up a new Rails project.
I follow the installation guide for shakapacker, and then follow the Getting Started directions for react_on_rails.
The command rails generate react_on_rails:install undoes required changes for Shakapacker v8 (it does not use the required generateWebpackConfig exports etc)

@vaukalak
Copy link
Contributor

Hello @timkrins and thanks for reporting the issue, it's on our track.

@Judahmeek @justin808 this should be addressed by #1622

@vaukalak
Copy link
Contributor

@timkrins it should be fixed by #1629 , feel free to re-open if it is not.

@coderabbitai coderabbitai bot mentioned this issue Jun 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants