Asset precompilation stage cannot cope with filenames with spaces in them

[samsondav]

Just updated react_on_rails to 6.0.5 and now I see this error precompiling assets:

React On Rails: Symlinking /Users/sam/code/projects/foo/public/assets/face on grey-93536981da08346bc1270aea2bcb27786769c3eb7b8f9966725a3b4bd3405202.png to /Users/sam/code/projects/foo/public/assets/face on grey.png
ln: grey.png: No such file or directory

Seems like React on Rails chokes on filenames with spaces in them.

[justin808]

Yes! Good catch.

Here's an example of where this is happening:
https://github.com/shakacode/react_on_rails/blob/master/lib/react_on_rails/assets_precompile.rb#L44

@samphilipd Any chance that you can submit a PR that has:

1. quotes the file name names (ln and rm commands in the file).
2. has a spec with a file that has spaces in the names.

[samsondav]

@justin808 It seems like this is caused because react_on_rails is trying to create non-digested versions of assets.

My question would be why not use something like this instead which is mature and has had all the bugs worked out?

[justin808]

alexspeller/non-stupid-digest-assets#35 amongst other reasons:
https://github.com/alexspeller/non-stupid-digest-assets/issues

Seems like that doesn't work on Heroku.

And no tests!

[samsondav]

@justin808 perhaps the asset linking part could be extracted out of react_on_rails into a separate gem?

I just feel like architecturally it's reaching a bit beyond scope here.

I'll see about a PR though if I have some time.

[justin808]

@samphilipd Since we want React on Rails to handle CSS Modules well, this is a natural inclusion.

[justin808]

@alleycat-at-git @robwise @samphilipd Rather than using ln -s source target, how about we use:

http://ruby-doc.org/core-2.2.0/File.html#method-c-symlink

We also need to set the directory:

http://apidock.com/ruby/FileUtils/cd

@dzirtusss Check this one out.

[dzirtusss]

I have send PR closing this

[justin808]

See #510.