Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use loader-utils.getOptions #28

Closed
BenDiuguid opened this issue Mar 14, 2017 · 3 comments
Closed

Use loader-utils.getOptions #28

BenDiuguid opened this issue Mar 14, 2017 · 3 comments
Labels
enhancement

Comments

@BenDiuguid
Copy link
Contributor

Hey, I just wanted to report this issue.

When using sass-resources-loader I am seeing this being logged when running webpack.

(node:68309) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
More found in this issue

I'm pretty sure this should be a simple change of updating loader-utils and changing the method from parseQuery to getOptions.

I'll try to have a PR for this soon! I just wanted to put this here first 😄
@BenDiuguid BenDiuguid mentioned this issue Mar 14, 2017
Merged
@justin808
Copy link
Member

@BenDiuguid We're reviewing. Sorry for the delay.

@BenDiuguid
Copy link
Contributor Author

It's all good, let me know if you need anything else!

@alex35mil
Copy link
Member

Merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justin808 @alex35mil @BenDiuguid