Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node20 #64

Open
grzegorzkrukowski opened this issue Jan 30, 2024 · 6 comments
Open

Upgrade to node20 #64

grzegorzkrukowski opened this issue Jan 30, 2024 · 6 comments

Comments

@grzegorzkrukowski
Copy link

This action requires Node20 to comply to latest GitHub requirements:

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@grzegorzkrukowski
Copy link
Author

@shallwefootball is there a chance this action will be compliant with the requirements or should we fork it instead and maintain it on our fork? Thanks in advance!

@grzegorzkrukowski
Copy link
Author

GitHub will enforce Node20 on May 13 - is there a chance this gets updated by that time?

@lvthanh03
Copy link
Contributor

+1 for upgrading to node20.

@xanderhendriks
Copy link
Contributor

@shallwefootball I also pushed PR 67 again from my fork. I went through the same process as in my earlier PR 46
Sorry @lvthanh03 I didn't see your update before making the changes in my fork. I did notice you didn't update the dependencies. Last time that gave me warnings, so I updated them again as part of the PR.
But even then I still see one warning regarding updating the aws-sdk to version 3.
I would be interested to know how to do this if everyone has come across this before as the version it upgraded to is the latest on the npmjs website.

@xanderhendriks
Copy link
Contributor

Looks like we still have some time before the current version of the action will stop working: https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/

@grzegorzkrukowski
Copy link
Author

grzegorzkrukowski commented Jul 22, 2024

It's fixed now with this commit also there is a PR opened to update te dependencies.

We need a new release to close this issue as not there is no way to use a fixed version as an action :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants