Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Visual Studio Online #1209

Open
LordChunk opened this issue May 24, 2020 · 11 comments
Open

Support for Visual Studio Online #1209

LordChunk opened this issue May 24, 2020 · 11 comments

Comments

@LordChunk
Copy link

Currently, when you try to install Settings Sync you get this error message:
Cannot install 'Settings Sync' because this extension has defined that it cannot run on the remote server.

It would be awesome if this feature became available for VSO (Visual Studio Online) as you frequently have to switch between workspaces, which means a lot of extension installations.

@rluvaton
Copy link

rluvaton commented Sep 13, 2020

@shanalikhan I Love this extension, are there any updates on this? Since GitHub Codespaces going to be publicly available soon, I think if this issue gonna be fixed people will have the perfect way to configure their codespace as they have on their local machine without a hassle.

@LordChunk
Copy link
Author

LordChunk commented Sep 20, 2020

I somewhat doubt this feature will be added any time soon given the lack of commits and the fact that Visual Studio Code now has its own settings synchronisation system.
#1188 (comment)
https://code.visualstudio.com/docs/editor/settings-sync

@theS1LV3R
Copy link

I somewhat doubt this feature will be added any time soon given the lack of commits and the fact that Visual Studio Code now has its own settings synchronisation system.

While VSCode does have its own sync system, its not a perfect soulution. Me for example, I use VSCodium, which likely won't add the sync feature of normal VSCode because of the amount of tracking that would likely be done. This extension also allows others to see my config easier than using the new syncing.

Therefore i would really love if the extension supported GitHub Codespaces (previously VSCode Online).

/cc @shanalikhan

@shanalikhan
Copy link
Owner

I'm open for PR. Feel free to contribute.

@theS1LV3R
Copy link

theS1LV3R commented Oct 25, 2020

Seems the setting that controls it is extensionKind in https://github.com/shanalikhan/code-settings-sync/blob/master/package.json. Is there any reason it is set to ["ui"] instead of ["ui", "workspace"] for example?

I'll do some testing and see if it works with different settings.

@n4nn31355
Copy link

@ent3r the problem is that you can have different settings in workspaces and therefore user settings will conflict with workspace settings.
For example, if you are using Remote Development, you will lose all your extensions in the backup.
Additional info: #870

@theS1LV3R
Copy link

So from what I just read it would have to be configured separately if it's a workspace setting, is that correct? I think it'd be worth it, considering (and correct me if im wrong) Github Codespaces uses the same workspace but different folders.

So the change that would be needed would be to just add "workspace" to the end of the array then?

@n4nn31355
Copy link

@ent3r sadly, but no. Just extending extensionKind with "workspace" will mess up the settings for those using the Remote Development feature(at least). So there should be another solution
One more link from previously noted issue #913

@theS1LV3R
Copy link

So there is no way to fix it then? Is there no way to get it to work on remotes or github codespaces?

@n4nn31355
Copy link

Hm, doc says:

"extensionKind": ["ui", "workspace"] — Indicates the extension prefers to run as a UI extension, but does not have any hard requirements on local assets, devices, or capabilities. When using VS Code, the extension will run in VS Code's local extension host if it exists locally, otherwise will run in VS Code's workspace extension host if it exists there.

So it might work, but needs to be tested with Remote Development.
Also, according to the doc, you can check if it will work in Codespaces by changing remote.extensionKind in the settings:

{
  "remote.extensionKind": {
    "ms-azuretools.vscode-cosmosdb": ["ui"],
    "msjsdiag.debugger-for-chrome": ["workspace"]
  }
}

@theS1LV3R
Copy link

theS1LV3R commented Oct 27, 2020

So i tried that, which did work!

...except it stopped installing once it reached "better comments", for the same reason as this extension.
Image of console

So if extensionKind was set to ["ui", "workspace"] and we added an if/else (try/catch?) here i think it'd be possible to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants