Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in the definition of build_loss, model.py(P1) #19

Open
DLPerf opened this issue Aug 27, 2021 · 1 comment
Open

Performance issue in the definition of build_loss, model.py(P1) #19

DLPerf opened this issue Aug 27, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 27, 2021

Hello, I found a performance issue in the definition of build_loss, model.py, tf.expand_dims(target_image, axis=-1) will be created repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@shaohua0116
Copy link
Owner

Thanks for the catch! Please create a PR so that your effort is recognized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants