Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTC(Input|Output)ScriptType.Bech32 is redundant and probably broken #461

Open
mrnerdhair opened this issue Mar 14, 2022 · 0 comments
Open

BTC(Input|Output)ScriptType.Bech32 is redundant and probably broken #461

mrnerdhair opened this issue Mar 14, 2022 · 0 comments
Labels
tech-debt A suboptimality that existed in code when it was written.
Milestone
hdwallet++

Comments

@mrnerdhair
Copy link
Contributor

Bech32 is an address encoding scheme, not a script type, and Bitcoin now uses it for more than one type of script too. Everywhere BTC(Input|Output)ScriptType.Bech32 is used, it should be SpendWitness instead.

  • Remove BTC(Input|Output)ScriptType.Bech32.

Fixed by #427.
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Mar 14, 2022
@mrnerdhair mrnerdhair linked a pull request Mar 17, 2022 that will close this issue
remove BTC(Input|Output)ScriptType.Bech32 #427
Closed
@mrnerdhair mrnerdhair added this to the hdwallet++ milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
hdwallet++
Development

Successfully merging a pull request may close this issue.

remove BTC(Input|Output)ScriptType.Bech32 shapeshift/hdwallet
1 participant
@mrnerdhair