Show error if Stripe publishable key is not configured #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
reviewed
Mar 6, 2019
src/translations/en.json
Outdated
| @@ -552,6 +552,7 @@ | |||
| "PayoutDetailsForm.lastNameLabel": "Last name", | |||
| "PayoutDetailsForm.lastNamePlaceholder": "Doe", | |||
| "PayoutDetailsForm.lastNameRequired": "This field is required", | |||
| "PayoutDetailsForm.missingStripeKey": "You need to configure the Stripe publishable key to continue.", | |||
There was a problem hiding this comment.
Providers see this message, so I think this should be changed to something like:
"Marketplace operator has not configured Stripe publishable key to this marketplace. Unfortunately, you can't publish listings yet."
OtterleyW
force-pushed
the
show-error-in-payout-modal-if-no-stripe-key
branch
2 times, most recently
from
c7926f3
to
c98f00f
Compare
OtterleyW
force-pushed
the
show-error-in-payout-modal-if-no-stripe-key
branch
from
c98f00f
to
d56ea31
Compare
Gnito
approved these changes
Mar 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show error in
PayoutDetailsFormand inStripePaymentFormif Stripe publishable key is not configured. This way the app will not crash e.g. if someone tries to publish a draft listing and the Stripe key is not configured yet.