-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intl #1181
Merged
Merged
Update intl #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
update-intl
branch
3 times, most recently
from
August 29, 2019 10:19
90a8704
to
7ed5a41
Compare
OtterleyW
force-pushed
the
update-react
branch
from
August 29, 2019 10:22
451b939
to
5e0c30a
Compare
Gnito
reviewed
Aug 29, 2019
Gnito
reviewed
Aug 29, 2019
Gnito
reviewed
Aug 29, 2019
Gnito
reviewed
Aug 29, 2019
OtterleyW
force-pushed
the
update-react
branch
from
August 29, 2019 12:16
5e0c30a
to
e4222be
Compare
Gnito
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OtterleyW
force-pushed
the
update-intl
branch
2 times, most recently
from
August 29, 2019 13:52
5d8a63f
to
713dc94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information about the changes can be found from Upgrade guide for [email protected]
intlShape
was removed so we needed to create it again. Because of this we added a newutil/reactIntl.js
file. This file is now used to wrap all the react-intl related imports.addLocaleDate
function was removed and react-intl library is now relying on native Intl APIs: Intl.PluralRules and Intl.RelativeTimeFormat. In order to support older browsers we needed to addintl-pluralrules
andintl-relativetimeformat
toutil/polyfills.js
full-icu
which caused changes tostart
andtest
scripts in
package.json
. We also needed to add a specific config fornodemon
textComponent
inIntlProvider
changed toReact.Fragment
so we need to explicitlyset
textComponent
tospan
. Otherwise all the snapshots would have changed and it might affect to UI if there is styles added to these spans generally in customization projects.Note:
FormattedMessage
component now supportstagName
prop and improved rich-text formatting.