Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Sharetribe Flex SDK to the 1.0.0 version in NPM #884

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

kpuputti
Copy link
Contributor

@kpuputti kpuputti commented Aug 7, 2018

This PR updates the template to use the newly released 1.0.0 version of the SDK in NPM.

The SDK itself only has some dependency updates and doesn't change any functionality or endpoint definitions.

CHANGELOG.md Outdated
@@ -14,6 +14,9 @@ way to update this template, but currently, we follow a pattern:
## Upcoming version 2018-08-XX
* [change] Reusable SearchMap. Fixed the original reverted version. (Includes audit exception 678)
[#882](https://github.com/sharetribe/flex-template-web/pull/882)
* [change] Update the Sharetribe Flex SDK to the 1.0.0 version in NPM.
All the `sharetribe-sdk` imports are now using the new package name
`sharetribe-flex-sdk`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have kept creation order with these (newest first)

Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse the changelog order

@@ -12,6 +12,9 @@ way to update this template, but currently, we follow a pattern:

---
## Upcoming version 2018-08-XX
* [change] Update the Sharetribe Flex SDK to the 1.0.0 version in NPM.
All the `sharetribe-sdk` imports are now using the new package name
`sharetribe-flex-sdk`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there's usually a link to the PR in the changelog entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order reversed and link added.

@kpuputti kpuputti merged commit 857490a into master Aug 7, 2018
@kpuputti kpuputti deleted the update-sdk branch August 7, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants