048.md

Bnke0x0

low

REMOVE UNUSED CODE

Summary

Vulnerability Detail

Impact

Empty blocks should be removed or emit something

Code Snippet

https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L1/L1ERC721Bridge.sol#L31 => {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L1/L1StandardBridge.sol#L101 => {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/BaseFeeVault.sol#L19 => constructor(address _recipient) FeeVault(_recipient, 10 ether) Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/GasPriceOracle.sol#L33 => constructor() Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/L1Block.sol#L65 => constructor() Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/L1FeeVault.sol#L19 => constructor(address _recipient) FeeVault(_recipient, 10 ether) Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/L2ERC721Bridge.sol#L31 => {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/L2StandardBridge.sol#L69 => {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/L2ToL1MessagePasser.sol#L70 => constructor() Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L2/SequencerFeeVault.sol#L20 => constructor(address _recipient) FeeVault(_recipient, 10 ether) Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/echidna/FuzzResourceMetering.sol#L129 => function _burnInternal(uint64 _gasToBurn) private metered(_gasToBurn) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/governance/GovernanceToken.sol#L18 => constructor() ERC20("Optimism", "OP") ERC20Permit("Optimism") {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/legacy/DeployerWhitelist.sol#L66 => constructor() Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/legacy/L1BlockNumber.sol#L22 => constructor() Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/legacy/LegacyERC20ETH.sol#L23 => {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/legacy/LegacyMessagePasser.sol#L23 => constructor() Semver(1, 0, 0) {} https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/universal/FeeVault.sol#L49 => receive() external payable {}

Tool used

Manual Review

Recommendation

This code is not used in the project, remove it or add event-emit;