Skip to content
This repository has been archived by the owner on Jun 23, 2024. It is now read-only.

klaus - FootiumClub NFTs do not support ERC2981 #130

Closed
sherlock-admin2 opened this issue Dec 17, 2023 · 1 comment
Closed

klaus - FootiumClub NFTs do not support ERC2981 #130

sherlock-admin2 opened this issue Dec 17, 2023 · 1 comment
Labels
Non-Reward This issue will not receive a payout

Comments

@sherlock-admin2
Copy link

sherlock-admin2 commented Dec 17, 2023 •
edited
Loading

klaus

medium

FootiumClub NFTs do not support ERC2981

Summary

Unlike FootiumPlayer, FootiumClub NFTs do not support ERC2981.

Vulnerability Detail

FootiumClub NFTs do not support ERC2981.

Some watsons pointed this out in past audit on 2023.04, and the protocol designer acknowledged this should be fixed. However, this has not been fixed and the same problem still exists.

Impact

Can't receive any fees for trading FootiumClub NFTs on the NFT market.

Code Snippet

https://github.com/sherlock-audit/2023-12-footium/blob/617cbc3df2fb51d9e8e5c701355efec4d4193d55/footium-eth-shareable/contracts/FootiumClub.sol#L14-L19

Tool used

Manual Review

Recommendation

Implement EIP2981 on clubs

Duplicate of #68
@sherlock-admin sherlock-admin changed the title Main Rose Boa - Malicious user can force Owner to waste gas Boxy Silver Mouse - FootiumClub NFTs do not support ERC2981 Dec 18, 2023
@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Dec 20, 2023
@sherlock-admin2
Copy link
Author

1 comment(s) were left on this issue during the judging contest.

darkart commented:

Even if team is sold the players are not directly connected to the team according to developers

@nevillehuang nevillehuang mentioned this issue Dec 20, 2023
Closed
@Czar102 Czar102 removed the Medium A valid Medium severity issue label Dec 21, 2023
@sherlock-admin2 sherlock-admin2 changed the title Boxy Silver Mouse - FootiumClub NFTs do not support ERC2981 klaus - FootiumClub NFTs do not support ERC2981 Dec 21, 2023
@sherlock-admin2 sherlock-admin2 added Non-Reward This issue will not receive a payout and removed Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Non-Reward This issue will not receive a payout
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Czar102 @sherlock-admin2