Stoicov - FootiumClub does not implement ERC2981

[sherlock-admin2]

Stoicov

medium

FootiumClub does not implement ERC2981

Summary

Footium players implement royalties while clubs do not, so marketplaces that do respect the EIP-2981 will not be paying royalties for the club NFTs which deprives developers from yield.

Vulnerability Detail

In the previous audit it was confirmed that clubs should implement ERC2981 Royalties which should go to the developers upon selling a club. However FootiumClub still does not inherit ERC2891Upgradeable.

contract FootiumClub is
    ERC721Upgradeable,
    AccessControlUpgradeable,
    PausableUpgradeable,
    ReentrancyGuardUpgradeable,
    OwnableUpgradeable
{

Impact

Loss of yield for Footium developers

Code Snippet

https://github.com/sherlock-audit/2023-12-footium/blob/main/footium-eth-shareable/contracts/FootiumClub.sol#L14-L19

This is the relevant issue, for which it was confirmed clubs should implement the EIP2981 standard so that on club sale royalties will be paid to the protocol developers, yet this has not been fixed, hence it is present in the current scope.
sherlock-audit/2023-04-footium-judging#293

The issue was found by 0x52 and 0xRobocop, so credit goes to them for spotting this.

Tool used

Manual Review

Recommendation

Implement EIP2981 on clubs as well

Duplicate of #68

[sherlock-admin2]

1 comment(s) were left on this issue during the judging contest.

darkart commented:

Even if team is sold the players are not directly connected to the team according to developers