Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Desktop icon still get's loaded in new GitHub Desktop versions #518

Closed
ivoxavier opened this issue Jun 1, 2021 · 5 comments · Fixed by #530
Closed

GitHub Desktop icon still get's loaded in new GitHub Desktop versions #518

ivoxavier opened this issue Jun 1, 2021 · 5 comments · Fixed by #530
Labels

Comments

@ivoxavier
Copy link

New one
Captura de ecrã de 2021-06-01 09-14-55

When opening it loads the old version in the launcher
Captura de ecrã de 2021-06-01 09-19-03

  • OS version
    Ubuntu 20.04

  • Desktop Environment
    GNOME

@Mrlinkwii
Copy link

odd , here , its updated 🤔
image

, can you you try using the very latest version (check releases )

@ivoxavier
Copy link
Author

Both my latop and desktop have this issue. Maybe I just uninstall and reinstall the app again. And yes, I'm running the latest version.

@shiftkey
Copy link
Owner

shiftkey commented Jun 7, 2021

I have a theory here that it's related to this line, which is specific to the Linux build:

windowOptions.icon = path.join(__dirname, 'static', 'icon-logo.png')

This is the window-specific icon, and might be overriding the default icon as part of the installer. That's pointing to this file, which is using the old style:

https://github.com/shiftkey/desktop/blob/a04c35efd3e23e652282d839875f65c88baa3bfb/app/static/linux/icon-logo.png

I haven't seen this on my 20.04 install either, but that's my best guess currently about where to investigate.

@Mrlinkwii
Copy link

@ivoxavier which install medium are you using (appimage , deb etc )

@ivoxavier
Copy link
Author

Hi, the deb package from this ppa: https://packagecloud.io/shiftkey/desktop/any/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants