Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Lit #725

Closed
3 of 4 tasks
JosefJezek opened this issue Jul 24, 2024 · 5 comments
Closed
3 of 4 tasks

Support for Lit #725

JosefJezek opened this issue Jul 24, 2024 · 5 comments

Comments

@JosefJezek
Copy link

Clear and concise description of the problem

Lit templates are written using JavaScript template literals tagged with the html tag. The contents of the literal are mostly plain, declarative, HTML:

static styles = css`
  :host {
    color: blue;
  }
`;

render() {
  return html`<p>Hello, ${this.name}!</p>`;
}

https://lit.dev/docs/components/overview/

Suggested solution

I don't know any solution.

Alternative

No response

Additional context

No response

Validations

Contributes

  • If this feature request is accepted, I am willing to submit a PR to fix this issue
@antfu antfu closed this as completed in 3107a2d Jul 26, 2024
@JosefJezek
Copy link
Author

@antfu Thank you 👍🏻

@JosefJezek
Copy link
Author

@antfu please add support for these tags

svg

const rect = svg`<rect width="10" height="10"></rect>`;
const myImage = html`
  <svg viewBox="0 0 10 10" xmlns="http://www.w3.org/2000/svg">
    ${rect}
  </svg>`;

https://lit.dev/docs/api/templates/#svg

math - MathML

const num = math`<mn>1</mn>`;

const eq = html`
   <math>
     ${num}
   </math>`;

lit/lit#4637

@antfu
Copy link
Member

antfu commented Jul 26, 2024

Feel free to send PRs and help out. I don't use Lit myself.

@JosefJezek
Copy link
Author

pls reopen issue

@antfu
Copy link
Member

antfu commented Aug 5, 2024

No. The original issue is resolved. You can't just keep asking more. Open source is voluntary, help out to move things forward.

diegohaz referenced this issue in ariakit/ariakit Aug 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [shiki](https://togithub.com/shikijs/shiki)
([source](https://togithub.com/shikijs/shiki/tree/HEAD/packages/shiki))
| [`1.10.3` ->
`1.12.1`](https://renovatebot.com/diffs/npm/shiki/1.10.3/1.12.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/shiki/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/shiki/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/shiki/1.10.3/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/shiki/1.10.3/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>shikijs/shiki (shiki)</summary>

### [`v1.12.1`](https://togithub.com/shikijs/shiki/releases/tag/v1.12.1)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.12.0...v1.12.1)

#####    🚀 Features

- New `dotenv` grammar, new `everforest` theme  -  by
[@&#8203;antfu](https://togithub.com/antfu)
[<samp>(29b1d)</samp>](https://togithub.com/shikijs/shiki/commit/29b1d3aa)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.12.0...v1.12.1)

### [`v1.12.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.12.0)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.11.2...v1.12.0)

#####    🚀 Features

- Add static `initial` method for `GrammarState`,
[#&#8203;715](https://togithub.com/shikijs/shiki/issues/715)  -  by
[@&#8203;antfu](https://togithub.com/antfu) in
[https://github.com/shikijs/shiki/issues/715](https://togithub.com/shikijs/shiki/issues/715)
[<samp>(be07d)</samp>](https://togithub.com/shikijs/shiki/commit/be07da89)
- New `ts-tags` grammar, lit support, close
[#&#8203;725](https://togithub.com/shikijs/shiki/issues/725)  -  by
[@&#8203;antfu](https://togithub.com/antfu) in
[https://github.com/shikijs/shiki/issues/725](https://togithub.com/shikijs/shiki/issues/725)
[<samp>(3107a)</samp>](https://togithub.com/shikijs/shiki/commit/3107a2d0)

#####    🐞 Bug Fixes

- **core**: Fix decoration offset edge cases  -  by
[@&#8203;timothycohen](https://togithub.com/timothycohen) in
[https://github.com/shikijs/shiki/issues/728](https://togithub.com/shikijs/shiki/issues/728)
[<samp>(1349b)</samp>](https://togithub.com/shikijs/shiki/commit/1349bb4d)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.11.2...v1.12.0)

### [`v1.11.2`](https://togithub.com/shikijs/shiki/releases/tag/v1.11.2)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.11.1...v1.11.2)

#####    🐞 Bug Fixes

- **core**: Fix the incorrect parameter when using a single theme  -  by
[@&#8203;il-1337](https://togithub.com/il-1337) in
[https://github.com/shikijs/shiki/issues/723](https://togithub.com/shikijs/shiki/issues/723)
[<samp>(5e2a6)</samp>](https://togithub.com/shikijs/shiki/commit/5e2a69e2)
- **rehype**: Add the misssing `CodeToHastOptionsCommon` to
`RehypeShikiCoreOptions` for `rehype` plugin  -  by
[@&#8203;fwqaaq](https://togithub.com/fwqaaq) in
[https://github.com/shikijs/shiki/issues/726](https://togithub.com/shikijs/shiki/issues/726)
[<samp>(c8c14)</samp>](https://togithub.com/shikijs/shiki/commit/c8c1468d)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.11.1...v1.11.2)

### [`v1.11.1`](https://togithub.com/shikijs/shiki/releases/tag/v1.11.1)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.11.0...v1.11.1)

#####    🐞 Bug Fixes

- CodeToTokens's includeExplanation option  -  by
[@&#8203;uxiew](https://togithub.com/uxiew) in
[https://github.com/shikijs/shiki/issues/718](https://togithub.com/shikijs/shiki/issues/718)
[<samp>(55e85)</samp>](https://togithub.com/shikijs/shiki/commit/55e857b8)
- **vitepress-twoslash**: Correct client types  -  by
[@&#8203;sxzz](https://togithub.com/sxzz) in
[https://github.com/shikijs/shiki/issues/720](https://togithub.com/shikijs/shiki/issues/720)
[<samp>(c8f30)</samp>](https://togithub.com/shikijs/shiki/commit/c8f301c9)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.11.0...v1.11.1)

### [`v1.11.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.11.0)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.10.3...v1.11.0)

#####    🚀 Features

- Update grammar and themes  -  by
[@&#8203;antfu](https://togithub.com/antfu)
[<samp>(91c7f)</samp>](https://togithub.com/shikijs/shiki/commit/91c7f016)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.10.3...v1.11.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [x] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/ariakit/ariakit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants