Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return list of applications based on selected timeframe #148

Closed
shini4i opened this issue Jun 16, 2023 · 1 comment · Fixed by #295
Closed

return list of applications based on selected timeframe #148

shini4i opened this issue Jun 16, 2023 · 1 comment · Fixed by #295
Assignees
Labels
technical dept an issue a tech. dept. something we need to fix to improve the quality of our code

Comments

@shini4i
Copy link
Owner

shini4i commented Jun 16, 2023

We are returning the complete list of available applications even if these applications were not deployed within the selected timeframe. It is misleading. Let's change it.

@shini4i shini4i added the technical dept an issue a tech. dept. something we need to fix to improve the quality of our code label Jun 16, 2023
@bozerkins
Copy link
Collaborator

There are two ways we can implement it. There's a proper way and a hacky way. Since we're planning long term for a proper HA mode and reliable UI, I would go with the first option. @shini4i , @tomsozolins would like to hear your input regarding this.

Option 1 (proper)

Backend changes

We change the tasks API so that it not only has application and timeframe filters, but limit as well. We'll do a backend-based pagination, meaning on every page change we'll be fetching records for that page from the backend.
For the API that returns applications, we would need to introduce timeframe filters.

Frontend change

In Frontend, we'll be doing a query to a database for a proper page on every page change (or filters change).
For the Application filter, we'll do a reload of the list of applications when the timeframe filter changes.

Option 2 (hacky)

Since we're currently loading all the tasks for all the pages in the timeframe, we can fetch distinct applications from the tasks that we receive. It's a very easy way to get the functionality right now, but this would also make the UI page very slow if we have a bigger timeframe and hundreds of deployments daily (thousands of records to render per page).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical dept an issue a tech. dept. something we need to fix to improve the quality of our code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants