Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move css inside a html to external file #22

Closed
shinneider opened this issue Dec 3, 2019 · 6 comments
Closed

Move css inside a html to external file #22

shinneider opened this issue Dec 3, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shinneider
Copy link
Owner

In the file django_admin_search/templates/admin/custom_search_form.html has many lines of css.

i need to move this lines of css, to a external css file, loaded in the html

@shinneider shinneider added enhancement New feature or request good first issue Good for newcomers labels Dec 3, 2019
@shinneider shinneider changed the title Move css inside a html to external css Move css inside a html to external file Dec 3, 2019
@gabbyprecious
Copy link
Contributor

Hello, I would love to work on this if it has not been achieved, can I work on it?

@shinneider
Copy link
Owner Author

Hi @gabbyprecious

can work on it :)

Assign to you and create a Pull Request to develop branch on finish.

gabbyprecious pushed a commit to gabbyprecious/django-admin-search that referenced this issue Feb 29, 2020
@gabbyprecious
Copy link
Contributor

I have sent a pull request, Please review and correction will be appreciated

@shinneider
Copy link
Owner Author

shinneider commented Feb 29, 2020

hi @gabbyprecious

i see the PR, and added a same comments, but i noticed that several "django tags" is reordened, not using a common django template recommendation.

however it seems to be something with its IDE (because they are lines of code that you haven't changed)

change not edited lines to back style and i approv the PR.

taking out of this inconvenience, it was very good job.

Nice. very thanks to contribute.

gabbyprecious pushed a commit to gabbyprecious/django-admin-search that referenced this issue Mar 1, 2020
gabbyprecious pushed a commit to gabbyprecious/django-admin-search that referenced this issue Mar 1, 2020
gabbyprecious pushed a commit to gabbyprecious/django-admin-search that referenced this issue Mar 1, 2020
@gabbyprecious
Copy link
Contributor

Hello I have sent a new pull request

shinneider added a commit that referenced this issue Mar 3, 2020
Move css inside a html to external file #22
@shinneider
Copy link
Owner Author

shinneider commented Mar 3, 2020

Hi @gabbyprecious

I approved and in the next release (0.3.4) your code will be present. :)

as there is no loss or gain in performance or any bugs, I will not upload the version immediately
wait to another issue to create a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants