temperatures - missing hwmon differences

[Tulux]

Hello,

On Linux, temperatures are collected by browsing /sys/class/hwmon/hwmon*/ but multiple hwmon may have same sensor name, ie :

> temp,host=lunatik,sensor=nvme_sensor_2 temp=73.85 1724328377000000000
> temp,host=lunatik,sensor=nvme_composite temp=39.85 1724328377000000000
> temp,host=lunatik,sensor=amdgpu_edge temp=43 1724328377000000000
> temp,host=lunatik,sensor=k10temp_tctl temp=53.875 1724328377000000000
> temp,host=lunatik,sensor=k10temp_tccd1 temp=47.875 1724328377000000000

-> 1st and 3rd lines have similar sensor tag values.

The issue comes from https://github.com/shirou/gopsutil/blob/master/sensors/sensors_linux.go#L94-L123 where SensorKey is composed of /sys/class/hwmon/hwmon*/name + _ + /sys/class/hwmon/hwmon*/temp_input :

gopsutil/sensors/sensors_linux.go

Line 103 in 904a5a4

name = name + "_" + label

which is not sufficient to discriminate similar devices such as nvme drives, HDDs, GPUs.

A solution would be adding hwmon number such as nameX_label (ie: nvme0_composite, nvme1_composite) although I am not sure whether the hwmon enumeration order is guaranteed, or prefix with vendor/device IDs however this might be more complicated since driver filesystem interfaces may differ.

Thank you

Florent